Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 11292003: [MIPS] Add build support in Skia for MIPS. (Closed)

Created:
8 years, 1 month ago by petarj
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Add build support in Skia for MIPS. Small change in skia.gyp to support building for MIPS arch. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165421

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M skia/skia.gyp View 5 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
petarj
8 years, 1 month ago (2012-10-26 00:55:11 UTC) #1
robertphillips
Added Eric & Elliot
8 years, 1 month ago (2012-10-26 12:01:06 UTC) #2
epoger
Seems fine to me (as long as you commit it after the M24 branch is ...
8 years, 1 month ago (2012-10-29 16:57:28 UTC) #3
petarj
On 2012/10/29 16:57:28, epoger wrote: > Seems fine to me (as long as you commit ...
8 years, 1 month ago (2012-11-01 00:56:47 UTC) #4
reed1
We have been trying hard to move as much of the gyp/gypi logic as makes ...
8 years, 1 month ago (2012-11-01 13:19:33 UTC) #5
epoger
Note that this change will conflict with https://chromiumcodereview.appspot.com/11342016/ ('Fix skia build when not on armv7.'). ...
8 years, 1 month ago (2012-11-01 14:12:05 UTC) #6
epoger
LGTM On 2012/11/01 13:19:33, reed1 wrote: > We have been trying hard to move as ...
8 years, 1 month ago (2012-11-01 14:14:47 UTC) #7
epoger
...and I believe the M24 branch was cut on Oct 30, so it should be ...
8 years, 1 month ago (2012-11-01 14:15:59 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-01 15:43:33 UTC) #9
reed1
lgtm
8 years, 1 month ago (2012-11-01 15:44:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/11292003/1
8 years, 1 month ago (2012-11-01 15:44:50 UTC) #11
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 17:46:28 UTC) #12
Change committed as 165421

Powered by Google App Engine
This is Rietveld 408576698