Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: ui/touch_selection/touch_selection_controller.h

Issue 1129193007: aw: Ensure synchronization of PopupWindow handle visibility/position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Slightly simpler visibility fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/touch_selection_controller.h
diff --git a/ui/touch_selection/touch_selection_controller.h b/ui/touch_selection/touch_selection_controller.h
index 7ec25d1d442e6d13bbdcb9c7990f4e61120e039d..4161e770790ac5a972537cf6964526ca8f29f185 100644
--- a/ui/touch_selection/touch_selection_controller.h
+++ b/ui/touch_selection/touch_selection_controller.h
@@ -129,9 +129,11 @@ class UI_TOUCH_SELECTION_EXPORT TouchSelectionController
void OnInsertionChanged();
void OnSelectionChanged();
- void ActivateInsertion();
+ // Returns true if insertion mode was newly (re)activated.
+ bool ActivateInsertionIfNecessary();
void DeactivateInsertion();
- void ActivateSelection();
+ // Returns true if selection mode was newly (re)activated.
+ bool ActivateSelectionIfNecessary();
void DeactivateSelection();
void ForceNextUpdateIfInactive();

Powered by Google App Engine
This is Rietveld 408576698