Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1129193006: fix winding for path ops builder (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

The path ops builder code needs to determine the winding of each contour added, and reverse windings if the contours are nested in other contours. Cheap (one contour) paths can be evaluated and reversed as needed with a minimum of checking, but multi-contour paths invoke the regular path ops machinery to determine who is contained by whom. More tests need to be added to verify that all corner cases are considered, but this fixes the cases in the bug thus far. R=fmalita@chromium.org TBR=reed@google.com BUG=skia:3838 Committed: https://skia.googlesource.com/skia/+/5b5ddd73b4baf22752924bf20d097e96236c36f8

Patch Set 1 #

Patch Set 2 : reverse contours as needed for path ops builder #

Patch Set 3 : fix compile bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -23 lines) Patch
M src/pathops/SkOpBuilder.cpp View 1 2 2 chunks +74 lines, -1 line 0 comments Download
M src/pathops/SkOpContour.h View 6 chunks +34 lines, -0 lines 0 comments Download
M src/pathops/SkOpContour.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 5 chunks +2 lines, -11 lines 0 comments Download
M src/pathops/SkPathOpsWinding.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 1 5 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129193006/10011
5 years, 7 months ago (2015-05-15 20:21:57 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/1099) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 7 months ago (2015-05-15 20:25:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129193006/30001
5 years, 7 months ago (2015-05-15 20:38:39 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-16 22:46:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129193006/30001
5 years, 7 months ago (2015-05-18 12:06:19 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 12:13:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://skia.googlesource.com/skia/+/5b5ddd73b4baf22752924bf20d097e96236c36f8

Powered by Google App Engine
This is Rietveld 408576698