Issue 1129193005: Random mandoline gn fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129193005: Random mandoline gn fixes (Closed)

Created:
5 years, 7 months ago by sky

Modified:
5 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, dcheng, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Random mandoline gn fixes These were needed to get a clean build working. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/1bd9da4e2c3bdbe923398089a80b82d9dc510c26 Cr-Commit-Position: refs/heads/master@{#329893}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	components/clipboard/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/runner/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/shell/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	mojo/shell/native_runner.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129193005/1

5 years, 7 months ago (2015-05-14 19:13:41 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 19:22:47 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1bd9da4e2c3bdbe923398089a80b82d9dc510c26
Cr-Commit-Position: refs/heads/master@{#329893}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages