Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 1129173006: Enable slimming paint by default (for trybots only) (Closed)

Created:
5 years, 7 months ago by Xianzhu
Modified:
5 years, 6 months ago
Reviewers:
wkorman
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable slimming paint by default (for trybots only)

Patch Set 1 #

Patch Set 2 : Enable RegionBasedColumns #

Patch Set 3 : Skip unit tests not compatible with slimming paint #

Patch Set 4 : Skip virtual/stable #

Patch Set 5 : Really enable slimming paint (previously was overriden by chrome prefs) #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : Sun May 10 14:51:37 PDT 2015 #

Patch Set 9 : Mon May 11 10:00:42 PDT 2015 #

Patch Set 10 : Mon May 11 11:46:34 PDT 2015 #

Patch Set 11 : Mon May 11 16:07:18 PDT 2015 #

Patch Set 12 : Mon May 11 18:47:58 PDT 2015 #

Patch Set 13 : Tue May 12 09:13:18 PDT 2015 #

Patch Set 14 : Thu May 14 10:42:25 PDT 2015 #

Patch Set 15 : Thu May 14 14:14:41 PDT 2015 #

Patch Set 16 : Mon May 18 13:45:05 PDT 2015 #

Patch Set 17 : Mon May 18 15:51:55 PDT 2015 #

Patch Set 18 : Tue May 19 08:46:21 PDT 2015 #

Patch Set 19 : Wed May 20 11:23:18 PDT 2015 #

Patch Set 20 : Wed May 20 19:00:12 PDT 2015 #

Patch Set 21 : Wed May 20 21:12:25 PDT 2015 #

Patch Set 22 : Thu May 21 09:12:48 PDT 2015 #

Patch Set 23 : Thu May 21 19:15:27 PDT 2015 #

Patch Set 24 : Fri May 22 11:11:58 PDT 2015 #

Patch Set 25 : Fri May 22 15:10:00 PDT 2015 #

Patch Set 26 : Fri May 22 19:03:24 PDT 2015 #

Patch Set 27 : Sat May 23 11:08:42 PDT 2015 #

Patch Set 28 : Sat May 23 22:44:42 PDT 2015 #

Patch Set 29 : Tue May 26 10:22:19 PDT 2015 #

Patch Set 30 : Thu May 28 13:53:44 PDT 2015 #

Patch Set 31 : Thu May 28 16:39:54 PDT 2015 #

Patch Set 32 : Thu May 28 18:20:47 PDT 2015 #

Patch Set 33 : Fri May 29 09:05:30 PDT 2015 #

Patch Set 34 : Mon Jun 1 09:34:45 PDT 2015 #

Patch Set 35 : Wed Jun 3 09:26:32 PDT 2015 #

Patch Set 36 : Remove slimming paint expectations for failing tests #

Patch Set 37 : Reset #

Patch Set 38 : Wed Jun 3 22:18:40 PDT 2015 #

Patch Set 39 : Wed Jun 3 23:52:22 PDT 2015 #

Patch Set 40 : Thu Jun 4 09:54:33 PDT 2015 #

Patch Set 41 : Fri Jun 5 08:57:56 PDT 2015 #

Patch Set 42 : Mon Jun 8 09:18:38 PDT 2015 #

Patch Set 43 : Mon Jun 8 22:44:06 PDT 2015 #

Patch Set 44 : Tue Jun 9 09:31:53 PDT 2015 #

Patch Set 45 : Tue Jun 9 10:33:43 PDT 2015 #

Total comments: 2

Patch Set 46 : Enable unit tests (not covered actually); Enable virtual/stable #

Patch Set 47 : Tue Jun 9 22:08:28 PDT 2015 #

Patch Set 48 : Wed Jun 10 09:18:10 PDT 2015 #

Patch Set 49 : Wed Jun 10 12:30:18 PDT 2015 #

Patch Set 50 : Wed Jun 10 21:49:56 PDT 2015 #

Patch Set 51 : Thu Jun 11 17:08:44 PDT 2015 #

Patch Set 52 : Thu Jun 11 23:11:37 PDT 2015 #

Patch Set 53 : Fri Jun 12 11:25:05 PDT 2015 #

Patch Set 54 : Fri Jun 12 12:12:47 PDT 2015 #

Patch Set 55 : Fri Jun 12 12:57:54 PDT 2015 #

Patch Set 56 : #

Patch Set 57 : Fri Jun 12 19:47:36 PDT 2015 #

Patch Set 58 : Mon Jun 15 08:59:36 PDT 2015 #

Patch Set 59 : Tue Jun 16 14:57:45 PDT 2015 #

Patch Set 60 : Tue Jun 16 17:49:58 PDT 2015 #

Patch Set 61 : Tue Jun 16 23:12:38 PDT 2015 #

Patch Set 62 : Wed Jun 17 15:43:32 PDT 2015 #

Patch Set 63 : Thu Jun 18 12:06:56 PDT 2015 #

Patch Set 64 : Fri Jun 19 14:04:25 PDT 2015 #

Patch Set 65 : Fri Jun 19 16:39:28 PDT 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -8 lines) Patch
A LayoutTests/SlimmingPaintExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 1 chunk +0 lines, -6 lines 0 comments Download
M Tools/Scripts/test-webkitpy View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 1 chunk +2 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 2 3 4 5 6 7 36 2 chunks +11 lines, -0 lines 0 comments Download
A sp/gen-auto-rebaseline View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 1 chunk +25 lines, -0 lines 0 comments Download
A sp/gen-expectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 1 chunk +18 lines, -0 lines 0 comments Download
A sp/last-auto-rebaseline View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +1 line, -0 lines 0 comments Download
A sp/statbugs View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 1 chunk +25 lines, -0 lines 0 comments Download
A sp/trybots View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
wkorman
https://codereview.chromium.org/1129173006/diff/930001/Source/web/tests/WebViewTest.cpp File Source/web/tests/WebViewTest.cpp (right): https://codereview.chromium.org/1129173006/diff/930001/Source/web/tests/WebViewTest.cpp#newcode509 Source/web/tests/WebViewTest.cpp:509: TEST_F(WebViewTest, DISABLED_SetBaseBackgroundColorAndBlendWithExistingContent) Do you remember what prompted need to ...
5 years, 6 months ago (2015-06-09 23:31:06 UTC) #7
Xianzhu
https://codereview.chromium.org/1129173006/diff/930001/Source/web/tests/WebViewTest.cpp File Source/web/tests/WebViewTest.cpp (right): https://codereview.chromium.org/1129173006/diff/930001/Source/web/tests/WebViewTest.cpp#newcode509 Source/web/tests/WebViewTest.cpp:509: TEST_F(WebViewTest, DISABLED_SetBaseBackgroundColorAndBlendWithExistingContent) On 2015/06/09 23:31:06, wkorman wrote: > Do ...
5 years, 6 months ago (2015-06-09 23:52:19 UTC) #8
Xianzhu
5 years, 6 months ago (2015-06-21 16:37:35 UTC) #11
Closing because we have enabled slimming paint for all layout tests.

Powered by Google App Engine
This is Rietveld 408576698