Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1129153002:
Update codereview settings to match new CQ project name. (Closed)
|
Created:
5 years, 7 months ago by Adrian Kuegel Modified:
5 years, 6 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref:
refs/remotes/origin/master Project:
depot_tools Visibility:
Public. |
DescriptionUpdate codereview settings to match new CQ project name.
BUG=420910
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295504
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
akuegel@chromium.org changed reviewers: + jochen@chromium.org
Jochen, can you please review this CL? This change is needed for splitting CQ for tools into depot_tools and tools_build.
akuegel@chromium.org changed reviewers: + phajdan.jr@chromium.org
+Pawel, who is also reviewing the CQ config change.
LGTM
lgtm
The CQ bit was checked by akuegel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 1129153002-1 failed and returned exit status 1. Running presubmit commit checks ... Initialized empty Git repository in /b/infra_internal/commit_queue/workdir/depot_tools/testing_support/_rietveld/.git/ Updating origin From https://chromium.googlesource.com/infra/infra * [new branch] deployed -> origin/deployed * [new branch] master -> origin/master From https://chromium.googlesource.com/infra/infra * branch master -> FETCH_HEAD Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** tests/git_rebase_update_test.py (87.90s) failed .Switched to branch foobar. Switched to branch sub_K. Switched to branch old_branch. Switched to branch empty_branch. Switched to branch empty_branch2. FSwitched to branch foobar. . ====================================================================== FAIL: testRebaseUpdate (__main__.GitRebaseUpdateTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_rebase_update_test.py", line 207, in testRebaseUpdate 'branch_L', 'old_branch', 'foobar'}) AssertionError: Items in the first set but not the second: 'origin/master)' ---------------------------------------------------------------------- Ran 3 tests in 87.422s FAILED (failures=1) Name Stmts Miss Cover Missing --------------------------------------------------- git_new_branch 28 0 100% git_rebase_update 144 0 100% git_rename_branch 29 0 100% git_reparent_branch 43 0 100% --------------------------------------------------- TOTAL 244 0 100% tests/git_common_test.py (30.72s) failed ...x....F.....FF........uCannot foo with a dirty tree. You must commit locally first. Uncommitted files: (git diff-index --name-status HEAD) A test.file ....... ====================================================================== FAIL: testGetBranchTree (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 536, in testGetBranchTree self.assertEqual(skipped, {'master', 'root_X', 'branch_DOG', 'root_CAT'}) AssertionError: Items in the first set but not the second: '78df7e3)' ====================================================================== FAIL: testTooManyBranches (__main__.GitMutableStructuredTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 464, in testTooManyBranches self.assertEqual(38, len(self.repo.run(list, self.gc.branches()))) AssertionError: 38 != 39 ====================================================================== FAIL: testBranches (__main__.GitReadOnlyFunctionsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "tests/git_common_test.py", line 235, in testBranches {'master', 'branch_D', 'root_A'}) AssertionError: Items in the first set but not the second: '696a838)' ---------------------------------------------------------------------- Ran 32 tests in 30.170s FAILED (failures=3, expected failures=1, unexpected successes=1) Name Stmts Miss Cover Missing ------------------------------------------ git_common 388 19 95% 319, 683-706 FATAL: not at 100% coverage. Presubmit checks took 164.4s to calculate.
The CQ bit was checked by akuegel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)
Patchset #2 (id:20001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by akuegel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129153002/1
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because it did not recognize the base URL. Please commit your change manually.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by akuegel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129153002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295504 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
