mojo/services/network/public/interfaces/http_message.mojom - Issue 1129143005: Introduce Http{Request,Response} mojom structs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/services/network/public/interfaces/http_message.mojom

Issue 1129143005: Introduce Http{Request,Response} mojom structs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module mojo;

	6

	7 struct HTTPHeader {
	yzshen1 2015/05/14 21:59:44 One issue that I haven't resolved is the naming in One issue that I haven't resolved is the naming inconsistency between HTTPHeader and HttpRequest/etc. HTTPHeader was used by url_loader.mojom so changing it will affect existing code. However, it seems the convention of chrome repo is to use "Http" in class/method names. What do you think? Thanks!
	8 string name;

	9 string value;

	10 };

	11

	12 struct HttpRequest {

	13 string method = "GET";

	14 string url;

	15 array<HTTPHeader>? headers;

	16 handle<data_pipe_consumer>? body;

	17 };

	18

	19 struct HttpResponse {

	20 uint32 status_code = 200;

	21 array<HTTPHeader>? headers;

	22 handle<data_pipe_consumer>? body;

	23 };

OLD	NEW