chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index 0852b824bb26978e9032b5304d4d29c19daf76a4..061fc6f86e5f57872d03c57d5056369287829fb4 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -466,7 +466,7 @@ class ExtensionLoadedNotificationObserver

}

// First part of extension installed message, the heading.

- base::string16 extension_name = UTF8ToUTF16(extension_->name().c_str());

+ base::string16 extension_name = base::UTF8ToUTF16(extension_->name().c_str());

base::i18n::AdjustStringForLocaleDirection(&extension_name);

[heading_ setStringValue:l10n_util::GetNSStringF(

IDS_EXTENSION_INSTALLED_HEADING, extension_name)];

@@ -493,7 +493,7 @@ class ExtensionLoadedNotificationObserver

if (type_ == extension_installed_bubble::kOmniboxKeyword) {

[howToUse_ setStringValue:l10n_util::GetNSStringF(

IDS_EXTENSION_INSTALLED_OMNIBOX_KEYWORD_INFO,

- UTF8ToUTF16(extensions::OmniboxInfo::GetKeyword(extension_)))];

+ base::UTF8ToUTF16(extensions::OmniboxInfo::GetKeyword(extension_)))];

[howToUse_ setHidden:NO];

[[howToUse_ cell]

setFont:[NSFont systemFontOfSize:[NSFont smallSystemFontSize]]];