chrome/browser/ui/cocoa/browser_window_controller_unittest.mm - Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm ('k') | chrome/browser/ui/cocoa/confirm_bubble_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

index ce5c71cac50ce0d4cacf59e512d8aff929fa9bb1..8611ec6c95ed32e101886d4720838361045191e4 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

@@ -660,7 +660,7 @@ TEST_F(BrowserWindowControllerTest, TestSigninMenuItemNoErrors) {

std::string username = "foo@example.com";

NSString* alreadySignedIn =

l10n_util::GetNSStringFWithFixup(IDS_SYNC_MENU_SYNCED_LABEL,

- UTF8ToUTF16(username));

+ base::UTF8ToUTF16(username));

SigninManager* signin = SigninManagerFactory::GetForProfile(profile());

signin->SetAuthenticatedUsername(username);

ProfileSyncService* sync =