chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm - Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_name_folder_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

index 27ec57cb5c9c58d650e1ad1ef081d3dc3b6ad300..ca18a59ae95691aefc46d12b8aa24ad767d3a846 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_model_observer_for_cocoa_unittest.mm

@@ -20,7 +20,7 @@ class BookmarkModelObserverForCocoaTest : public CocoaProfileTest {

TEST_F(BookmarkModelObserverForCocoaTest, TestCallback) {

BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

const BookmarkNode* node = model->AddURL(model->bookmark_bar_node(),

- 0, ASCIIToUTF16("super"),

+ 0, base::ASCIIToUTF16("super"),

GURL("http://www.google.com"));

__block size_t pings = 0U;

@@ -41,7 +41,7 @@ TEST_F(BookmarkModelObserverForCocoaTest, TestCallback) {

EXPECT_EQ(0U, pings);

EXPECT_EQ(0U, deletions);

- model->SetTitle(node, ASCIIToUTF16("duper"));

+ model->SetTitle(node, base::ASCIIToUTF16("duper"));

EXPECT_EQ(1U, pings);

EXPECT_EQ(0U, deletions);