chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm - Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

Issue 112913004: Update some uses of UTF conversions in chrome/browser to use the base:: namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

index 12b6850ca892e6e93cefe0e57e262089426c86fa..9a2b12ded2f4ce8c7ace6d53197e71ab9b765b88 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

@@ -95,7 +95,7 @@ TEST_F(BookmarkButtonTest, FolderAndEmptyOrNot) {

EXPECT_TRUE([button isFolder]);

EXPECT_EQ([button bookmarkNode], node);

- node = model->AddURL(node, 0, ASCIIToUTF16("hi mom"),

+ node = model->AddURL(node, 0, base::ASCIIToUTF16("hi mom"),

GURL("http://www.google.com"));

[cell setBookmarkNode:node];

EXPECT_FALSE([button isEmpty]);

@@ -143,7 +143,8 @@ TEST_F(BookmarkButtonTest, DragToTrash) {

// Add a deletable bookmark to the button.

BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

const BookmarkNode* barNode = model->bookmark_bar_node();

- const BookmarkNode* node = model->AddURL(barNode, 0, ASCIIToUTF16("hi mom"),

+ const BookmarkNode* node = model->AddURL(barNode, 0,

+ base::ASCIIToUTF16("hi mom"),

GURL("http://www.google.com"));

[cell setBookmarkNode:node];