Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1129113003: Add DEPS hooks to download gn/clang-format binaries on mac (Closed)

Created:
5 years, 7 months ago by jamesr
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
Chinmay, cdotstout, mojo-reviews_chromium.org, toshik
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M DEPS View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
5 years, 7 months ago (2015-05-07 00:57:23 UTC) #1
jamesr
5 years, 7 months ago (2015-05-07 18:12:16 UTC) #2
eseidel
Woohoo!
5 years, 7 months ago (2015-05-07 18:13:41 UTC) #3
jamesr
On 2015/05/07 18:13:41, eseidel wrote: > Woohoo! nice but not quite the 4 letters i ...
5 years, 7 months ago (2015-05-07 18:27:57 UTC) #4
eseidel
lgtm
5 years, 7 months ago (2015-05-07 18:28:52 UTC) #5
jamesr
5 years, 7 months ago (2015-05-07 18:29:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06683f425a26bd0e2171cb876a46b1f09f477eb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698