Converting file_display_name_ type from base::string16 to base::FilePath.

Converting file_display_name_ type from base::string16 to base::FilePath.

This is for making type of file_to_install and file_display_name_ consistent.

BUG=486616
Committed: https://crrev.com/7fc55d025effb04cb03b00d8a71e9a0992df70bb
Cr-Commit-Position: refs/heads/master@{#329581}

[Deepak, 2015-05-11 05:41:25]

deepak.m1@samsung.com changed reviewers:
+ kalman@chromium.org

[Deepak, 2015-05-11 05:41:25]

PTAL at this small change.

[not at google - send to devlin, 2015-05-11 18:06:07]

kalman@chromium.org changed reviewers:
+ dcheng@chromium.org

[not at google - send to devlin, 2015-05-11 18:06:07]

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/install_extension_handler.cc (left):

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/install_extension_handler.cc:82: //
TODO(dcheng): It would be nice to make this a FilePath too.
I don't understand this TODO and disagree with this change. dcheng@ - context?

[dcheng, 2015-05-11 18:16:15]

I was doing some cleanup in drag and drop code awhile back, when I noticed a
bunch of conversions between FilePath and string16
(https://chromium.googlesource.com/chromium/src/+/17ea0ae233fa0deef9df089ccfdf...).

This is one of the places I didn't clean up at the time. Is there a reason these
checks need to be case sensitive?

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/install_extension_handler.cc (right):

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/install_extension_handler.cc:104: if
(EndsWith(file_display_name_.AsUTF16Unsafe(), base::ASCIIToUTF16(".zip"),
Why not FilePath::MatchesExtension()?

That being said, I'm not sure why this is case sensitive.

[not at google - send to devlin, 2015-05-11 18:28:32]

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/install_extension_handler.cc (right):

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/install_extension_handler.cc:104: if
(EndsWith(file_display_name_.AsUTF16Unsafe(), base::ASCIIToUTF16(".zip"),
On 2015/05/11 18:16:15, dcheng wrote:
> Why not FilePath::MatchesExtension()?
> 
> That being said, I'm not sure why this is case sensitive.

Using MatchesExtension would make this change much nicer. I presume that the
file extensions of the non-display-name isn't preserved when it's some hash.
That would be pretty weird if it were.

[Deepak, 2015-05-12 05:41:58]

Changes done as suggested.
PTAL.

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
File chrome/browser/ui/webui/extensions/install_extension_handler.cc (right):

https://codereview.chromium.org/1129103006/diff/1/chrome/browser/ui/webui/ext...
chrome/browser/ui/webui/extensions/install_extension_handler.cc:104: if
(EndsWith(file_display_name_.AsUTF16Unsafe(), base::ASCIIToUTF16(".zip"),
On 2015/05/11 18:28:32, kalman wrote:
> On 2015/05/11 18:16:15, dcheng wrote:
> > Why not FilePath::MatchesExtension()?
> > 
> > That being said, I'm not sure why this is case sensitive.
> 
> Using MatchesExtension would make this change much nicer. I presume that the
> file extensions of the non-display-name isn't preserved when it's some hash.
> That would be pretty weird if it were.

I agree with you, Anyways kCaseSensitive value is always flase in our case and
FilePath::MatchesExtension() ignore case.
So we can directly use FilePath::MatchesExtension().

[not at google - send to devlin, 2015-05-12 20:50:20]

lgtm

[Deepak, 2015-05-13 02:36:24]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-05-13 02:36:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129103006/20001

[commit-bot: I haz the power, 2015-05-13 03:40:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-13 03:40:56]

Patchset 2 (id:??) landed as
https://crrev.com/7fc55d025effb04cb03b00d8a71e9a0992df70bb
Cr-Commit-Position: refs/heads/master@{#329581}

[Deepak, 2015-05-13 06:44:02]

On 2015/05/12 20:50:20, kalman wrote:
> lgtm

Thanks @kalman.