Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Factoring out debug log message function Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 6fdd5cf1c0fea885c956f7c3bb58acf210e62c43..d43b72291795cf564feb89e38bca752ac4765ffa 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -6,6 +6,7 @@
#include "base/metrics/field_trial.h"
#include "chrome/browser/banners/app_banner_data_fetcher.h"
+#include "chrome/browser/banners/app_banner_debug_log.h"
#include "chrome/browser/banners/app_banner_settings_helper.h"
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/render_frame_host.h"
@@ -49,8 +50,11 @@ void AppBannerManager::DidFinishLoad(
// A secure scheme is required to show banners, so exit early if we see the
// URL is invalid.
- if (!validated_url.SchemeIsSecure() && !gDisableSecureCheckForTesting)
+ if (!validated_url.SchemeIsSecure() && !gDisableSecureCheckForTesting) {
+ SendDebugMessage(web_contents(),
+ "not shown: page not served over secure scheme");
benwells 2015/05/11 08:08:40 FYI this is about to go out of date. To match the
dominickn (DO NOT USE) 2015/05/12 07:41:31 Done.
return;
+ }
// Kick off the data retrieval pipeline.
data_fetcher_ = CreateAppBannerDataFetcher(weak_factory_.GetWeakPtr(),

Powered by Google App Engine
This is Rietveld 408576698