Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_unittest.cc

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Factoring out debug log message function Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher_unittest.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
index 2254130433b6c01e5066a7bc7d6489e2f5686cfa..00e8a9e9d96d01ada3102fbe2c08444c61cc1c8b 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_unittest.cc
@@ -33,7 +33,9 @@ class AppBannerDataFetcherUnitTest : public testing::Test {
}
static bool IsManifestValid(const content::Manifest& manifest) {
- return AppBannerDataFetcher::IsManifestValidForWebApp(manifest);
+ // second argument is the web_contents pointer to allow debug logging
+ // to the console. logging doesn't take place if the pointer is null
benwells 2015/05/11 08:08:40 Please use proper case, class names and grammar in
dominickn (DO NOT USE) 2015/05/12 07:41:31 Done.
+ return AppBannerDataFetcher::IsManifestValidForWebApp(manifest, nullptr);
}
};

Powered by Google App Engine
This is Rietveld 408576698