Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Factoring out debug log message function Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index 6327453104c4ede3b678af17efe235115dd88da2..43f5e0eb31e1570fbada43599f980c7d2c3ab3ae 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -138,14 +138,21 @@ class AppBannerDataFetcher
// Returns whether the banner should be shown.
bool CheckIfShouldShowBanner();
+ // Returns whether the fetcher is active and web contents have not been
+ // closed
+ bool CheckFetcherIsStillAlive(content::WebContents* web_contents,
+ const std::string& section);
+
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
- static bool IsManifestValidForWebApp(const content::Manifest& manifest);
+ static bool IsManifestValidForWebApp(const content::Manifest& manifest,
+ content::WebContents* web_contents);
const int ideal_icon_size_;
const base::WeakPtr<Delegate> weak_delegate_;
ObserverList<Observer> observer_list_;
bool is_active_;
+ bool log_err_;
benwells 2015/05/11 08:08:40 Is this needed?
dominickn (DO NOT USE) 2015/05/12 07:41:31 Done.
int event_request_id_;
scoped_ptr<chrome::BitmapFetcher> bitmap_fetcher_;
scoped_ptr<SkBitmap> app_icon_;

Powered by Google App Engine
This is Rietveld 408576698