Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3889)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a full stop to the end of a comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 829b0b019296829cc6feabd9b4eaf49d56749ae7..a5eaebcb3587c18135c5f663aa825aaa80729a93 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -51,7 +51,7 @@ void AppBannerManagerAndroid::ReplaceWebContents(JNIEnv* env,
bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
const GURL& url,
const std::string& id) {
- if (platform != kPlayPlatform || id.empty())
+ if (!CheckPlatformAndId(platform, id))
return false;
banners::TrackDisplayEvent(DISPLAY_EVENT_BANNER_REQUESTED);
@@ -71,6 +71,33 @@ bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
return true;
}
+bool AppBannerManagerAndroid::CheckPlatformAndId(const std::string& platform,
+ const std::string& id) {
+ if (platform != kPlayPlatform) {
+ banners::OutputDeveloperDebugMessage(
+ web_contents(), platform + banners::kIgnoredNotSupportedOnAndroid);
+ return false;
+ }
+ if (id.empty()) {
+ banners::OutputDeveloperDebugMessage(web_contents(), banners::kIgnoredNoId);
+ return false;
+ }
+ return true;
+}
+
+bool AppBannerManagerAndroid::CheckFetcherMatchesContents() {
+ if (!web_contents()) {
+ return false;
+ }
+ if (!data_fetcher() ||
+ data_fetcher()->validated_url() != web_contents()->GetURL()) {
+ banners::OutputDeveloperNotShownMessage(
+ web_contents(), banners::kUserNavigatedBeforeBannerShown);
+ return false;
+ }
+ return true;
+}
+
AppBannerDataFetcher* AppBannerManagerAndroid::CreateAppBannerDataFetcher(
base::WeakPtr<Delegate> weak_delegate,
const int ideal_icon_size) {
@@ -84,10 +111,8 @@ bool AppBannerManagerAndroid::OnAppDetailsRetrieved(JNIEnv* env,
jstring japp_title,
jstring japp_package,
jstring jicon_url) {
- if (!data_fetcher() || !web_contents()
- || data_fetcher()->validated_url() != web_contents()->GetURL()) {
+ if (!CheckFetcherMatchesContents())
return false;
- }
base::android::ScopedJavaLocalRef<jobject> native_app_data;
native_app_data.Reset(env, japp_data);
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.h ('k') | chrome/browser/banners/app_banner_data_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698