Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2985)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index ce6d8e3013fe178b19e22b6ac4aabc99beaf38dd..d4b7133f2338e23621be380404ccee1f5f48c500 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -137,6 +137,10 @@ class AppBannerDataFetcher
// Returns whether the banner should be shown.
bool CheckIfShouldShowBanner();
+ // Logs a debug message to the main console if a banner could not be shown
+ // and the engagement checks have been bypassed.
+ void SendDebugMessage(const std::string& message);
+
// Returns whether the given Manifest is following the requirements to show
// a web app banner.
static bool IsManifestValidForWebApp(const content::Manifest& manifest);
@@ -145,6 +149,7 @@ class AppBannerDataFetcher
const base::WeakPtr<Delegate> weak_delegate_;
ObserverList<Observer> observer_list_;
bool is_active_;
+ bool log_err_;
scoped_ptr<chrome::BitmapFetcher> bitmap_fetcher_;
scoped_ptr<SkBitmap> app_icon_;
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | chrome/browser/banners/app_banner_data_fetcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698