Log messages regarding why app banners aren't displayed to the console

chrome/browser/banners/app_banner_debug_log.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/banners/app_banner_debug_log.h"
+
+#include "base/command_line.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/render_messages.h"
+#include "content/public/browser/render_frame_host.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_observer.h"
+
+namespace banners {
+
+void SendDebugMessage(content::WebContents* web_contents,

[benwells, 2015/05/11 08:08:40]

This name is very vague. Debug usually refers to chrome developers debug. Maybe
'OutputDeveloperMessage' would be better. Or something.

[dominickn (DO NOT USE), 2015/05/12 07:41:31]

Done.

+                      const std::string& message) {
+  std::string log_message = "App banner " + message;

[benwells, 2015/05/11 08:08:40]

Should this be "App banner: " with a colon?

Edit: Ah, I see now. We should prevent the 'not shown' being repeated
everywhere. Either just add it unconditionally here, or if it is not always used
have two versions of the function.

[dominickn (DO NOT USE), 2015/05/12 07:41:31]

Done.

+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kBypassAppBannerEngagementChecks) && web_contents) {
+    web_contents->GetMainFrame()->Send(
+        new ChromeViewMsg_AppBannerDebugMessageRequest(
+            web_contents->GetMainFrame()->GetRoutingID(), log_message));
+  }
+}
+
+};  // namespace banners

[benwells, 2015/05/11 08:08:40]

Nit: no ";"

[dominickn (DO NOT USE), 2015/05/12 07:41:31]

Done.