Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a full stop to the end of a comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_
7 7
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_weak_ref.h" 9 #include "base/android/jni_weak_ref.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "chrome/browser/android/banners/app_banner_data_fetcher_android.h" 11 #include "chrome/browser/android/banners/app_banner_data_fetcher_android.h"
12 #include "chrome/browser/banners/app_banner_debug_log.h"
12 #include "chrome/browser/banners/app_banner_manager.h" 13 #include "chrome/browser/banners/app_banner_manager.h"
13 14
14 namespace banners { 15 namespace banners {
15 class AppBannerDataFetcherAndroid; 16 class AppBannerDataFetcherAndroid;
16 17
17 // Extends the AppBannerManager to support native Android apps. 18 // Extends the AppBannerManager to support native Android apps.
18 // TODO(dfalcantara): Flip it so the C++ AppBannerManagerAndroid owns the 19 // TODO(dfalcantara): Flip it so the C++ AppBannerManagerAndroid owns the
19 // Java AppBannerManager, move ownership of the AppBannerManagerAndroid to 20 // Java AppBannerManager, move ownership of the AppBannerManagerAndroid to
20 // the TabAndroid class, then move functions for retriving info from Java to 21 // the TabAndroid class, then move functions for retriving info from Java to
21 // the AppBannerDataFetcherAndroid. 22 // the AppBannerDataFetcherAndroid.
(...skipping 29 matching lines...) Expand all
51 AppBannerDataFetcher* CreateAppBannerDataFetcher( 52 AppBannerDataFetcher* CreateAppBannerDataFetcher(
52 base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate, 53 base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
53 const int ideal_icon_size) override; 54 const int ideal_icon_size) override;
54 55
55 private: 56 private:
56 // AppBannerDataFetcher::Delegate overrides. 57 // AppBannerDataFetcher::Delegate overrides.
57 bool HandleNonWebApp(const std::string& platform, 58 bool HandleNonWebApp(const std::string& platform,
58 const GURL& url, 59 const GURL& url,
59 const std::string& id) override; 60 const std::string& id) override;
60 61
62 bool CheckPlatformAndId(const std::string& platform, const std::string& id);
63
64 bool CheckFetcherMatchesContents();
65
61 // AppBannerManager on the Java side. 66 // AppBannerManager on the Java side.
62 JavaObjectWeakGlobalRef weak_java_banner_view_manager_; 67 JavaObjectWeakGlobalRef weak_java_banner_view_manager_;
63 68
64 DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid); 69 DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid);
65 }; // class AppBannerManagerAndroid 70 }; // class AppBannerManagerAndroid
66 71
67 } // namespace banners 72 } // namespace banners
68 73
69 #endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ 74 #endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/banners/app_banner_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698