Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: chrome/common/render_messages.h

Issue 1129103003: Log messages regarding why app banners aren't displayed to the console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Multiply-included file, no traditional include guard. 5 // Multiply-included file, no traditional include guard.
6 #include <stdint.h> 6 #include <stdint.h>
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 // Tells the browser that we blocked a plugin because NPAPI is not supported. 446 // Tells the browser that we blocked a plugin because NPAPI is not supported.
447 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_NPAPINotSupported, 447 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_NPAPINotSupported,
448 std::string /* identifer */) 448 std::string /* identifer */)
449 449
450 // Asks the renderer whether an app banner should be shown. It will reply with 450 // Asks the renderer whether an app banner should be shown. It will reply with
451 // ChromeViewHostMsg_AppBannerPromptReply. 451 // ChromeViewHostMsg_AppBannerPromptReply.
452 IPC_MESSAGE_ROUTED2(ChromeViewMsg_AppBannerPromptRequest, 452 IPC_MESSAGE_ROUTED2(ChromeViewMsg_AppBannerPromptRequest,
453 int /* request_id */, 453 int /* request_id */,
454 std::string /* platform */) 454 std::string /* platform */)
455 455
456 // Asks the renderer to log a debug message to console regarding a
457 // non-displayed app banner
benwells 2015/05/07 01:57:20 Nit: techincally this is incorrect as we also log
dominickn (DO NOT USE) 2015/05/07 05:37:24 Done.
458 IPC_MESSAGE_ROUTED1(ChromeViewMsg_AppBannerDebugMessageRequest,
459 std::string /* message */)
460
456 // Notification that the page has an OpenSearch description document 461 // Notification that the page has an OpenSearch description document
457 // associated with it. 462 // associated with it.
458 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_PageHasOSDD, 463 IPC_MESSAGE_ROUTED3(ChromeViewHostMsg_PageHasOSDD,
459 GURL /* page_url */, 464 GURL /* page_url */,
460 GURL /* osdd_url */, 465 GURL /* osdd_url */,
461 search_provider::OSDDType) 466 search_provider::OSDDType)
462 467
463 // Find out if the given url's security origin is installed as a search 468 // Find out if the given url's security origin is installed as a search
464 // provider. 469 // provider.
465 IPC_SYNC_MESSAGE_ROUTED2_1(ChromeViewHostMsg_GetSearchProviderInstallState, 470 IPC_SYNC_MESSAGE_ROUTED2_1(ChromeViewHostMsg_GetSearchProviderInstallState,
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 607
603 // Record a sample string to a Rappor metric. 608 // Record a sample string to a Rappor metric.
604 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor, 609 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor,
605 std::string /* metric */, 610 std::string /* metric */,
606 std::string /* sample */) 611 std::string /* sample */)
607 612
608 // Record a domain and registry of a url to a Rappor metric. 613 // Record a domain and registry of a url to a Rappor metric.
609 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL, 614 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL,
610 std::string /* metric */, 615 std::string /* metric */,
611 GURL /* sample url */) 616 GURL /* sample url */)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698