Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1129103002: Revert of Actually use --extra-r-text-files in process_resources.py (Closed)

Created:
5 years, 7 months ago by cjhopman
Modified:
5 years, 7 months ago
Reviewers:
msw, Yaron, Ian Cullinan
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Actually use --extra-r-text-files in process_resources.py (patchset #6 id:90001 of https://codereview.chromium.org/1104703003/) Reason for revert: Breaks gn apks with no resources. Original issue's description: > Actually use --extra-r-text-files in process_resources.py > > Generate extra packages' R.java files only containing the resources > listed in their R.txt files. This significantly reduces the number of > DEX field IDs taken up by resources. > > BUG=480036 > R=cjhopman > > Committed: https://crrev.com/a92cf235709397c737d5d9fdbadfb62e497c0334 > Cr-Commit-Position: refs/heads/master@{#328565} TBR=yfriedman@chromium.org,msw@chromium.org,cullinan@amazon.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480036 Committed: https://crrev.com/61ff577cdede4b1e04846ef4af71659d194219b0 Cr-Commit-Position: refs/heads/master@{#328664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -120 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/gyp/process_resources.py View 7 chunks +21 lines, -95 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +0 lines, -6 lines 0 comments Download
M build/config/android/internal_rules.gni View 4 chunks +0 lines, -11 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +0 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
Created Revert of Actually use --extra-r-text-files in process_resources.py
5 years, 7 months ago (2015-05-07 00:33:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129103002/1
5 years, 7 months ago (2015-05-07 00:35:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 00:36:41 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 00:37:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61ff577cdede4b1e04846ef4af71659d194219b0
Cr-Commit-Position: refs/heads/master@{#328664}

Powered by Google App Engine
This is Rietveld 408576698