Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 1129083007: Replace EVP_PKEY_dup calls with EVP_PKEY_up_ref. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace EVP_PKEY_dup calls with EVP_PKEY_up_ref. This is a no-op change. BoringSSL deprecated EVP_PKEY_dup in favor of a new EVP_PKEY_up_ref. This makes it more obvious there isn't actually a copy and is more consistent with other ref-counted types. See https://boringssl.googlesource.com/boringssl/+/517da2f1efc91b179dfb1898f826b18a6a38f547%5E%21/#F3 BUG=none Committed: https://crrev.com/c681bac0d7e8c3777c8cc80d149932c8a438579b Cr-Commit-Position: refs/heads/master@{#329732}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M crypto/ec_private_key_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/rsa_private_key_openssl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/base/openssl_private_key_store_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/openssl_client_key_store.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Here, have a tiny five minute CL.
5 years, 7 months ago (2015-05-13 20:54:13 UTC) #2
Ryan Sleevi
Your up ref goer five CL LGTM ( https://xkcd.com/1133/ )
5 years, 7 months ago (2015-05-13 22:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129083007/20001
5 years, 7 months ago (2015-05-13 22:09:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 22:15:06 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:15:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c681bac0d7e8c3777c8cc80d149932c8a438579b
Cr-Commit-Position: refs/heads/master@{#329732}

Powered by Google App Engine
This is Rietveld 408576698