AADistanceFieldPathRenderer unit tests

AADistanceFieldPathRenderer unit tests

TBR=bsalomon@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/21279c7ada1e47e8bfc6375f67768c8eedffb680

[joshualitt, 2015-05-07 16:58:25]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-05-07 16:58:26]

ptal, Brian for API

[robertphillips, 2015-05-07 19:30:24]

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
File src/gpu/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
src/gpu/GrAADistanceFieldPathRenderer.cpp:623: typedef
GrAADistanceFieldPathRenderer::PathDataList PathDataList;
PathTestStruct() : fContextID(0), fAtlas(NULL) {} 

assuming 0 is an invalid ID for the context

?

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
src/gpu/GrAADistanceFieldPathRenderer.cpp:657: GrBatchAtlas* fAtlas;
Just PathCache as the type ?

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
src/gpu/GrAADistanceFieldPathRenderer.cpp:665: 
Would initializing fContextID to zero allow us to get rid of 'gInit' ?

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:175: SkStrokeRec::InitStyle style =
Should we add a 'kInitStyleCount ' ?

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:178: bool strokeAndFill = random->nextBool();
A width one too? Maybe 10?

[joshualitt, 2015-05-07 21:22:39]

feedback incorporated + questions

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
File src/gpu/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
src/gpu/GrAADistanceFieldPathRenderer.cpp:623: typedef
GrAADistanceFieldPathRenderer::PathDataList PathDataList;
On 2015/05/07 19:30:24, robertphillips wrote:
> PathTestStruct() : fContextID(0), fAtlas(NULL) {} 
> 
> assuming 0 is an invalid ID for the context
> 
> ?

Acknowledged.

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
src/gpu/GrAADistanceFieldPathRenderer.cpp:657: GrBatchAtlas* fAtlas;
On 2015/05/07 19:30:24, robertphillips wrote:
> Just PathCache as the type ?

Acknowledged.

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrAADistanceFieldPa...
src/gpu/GrAADistanceFieldPathRenderer.cpp:665: 
On 2015/05/07 19:30:24, robertphillips wrote:
> Would initializing fContextID to zero allow us to get rid of 'gInit' ?

Acknowledged.

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:175: SkStrokeRec::InitStyle style =
On 2015/05/07 19:30:24, robertphillips wrote:
> Should we add a 'kInitStyleCount ' ?

Well, there is a macro which Mike Klein made to make auto counting enums. 
Otherwise, I'd rather not add a count.

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:178: bool strokeAndFill = random->nextBool();
On 2015/05/07 19:30:24, robertphillips wrote:
> A width one too? Maybe 10?

you want me to make an enum of possible widths with 10 values?  I want to be
careful playing with the width because some of the renderers expect strokewidth
to be sane relative to the geometry they draw.

[robertphillips, 2015-05-08 12:02:07]

lgtm + nits

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1129083005/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:178: bool strokeAndFill = random->nextBool();
I was just angling for a wider one (i.e., a stroke width of 10) but it sounds
like that could cause problems.

https://codereview.chromium.org/1129083005/diff/20001/src/gpu/GrAADistanceFie...
File src/gpu/GrAADistanceFieldPathRenderer.cpp (right):

https://codereview.chromium.org/1129083005/diff/20001/src/gpu/GrAADistanceFie...
src/gpu/GrAADistanceFieldPathRenderer.cpp:659: 
add space between 'if' and '(' ?

https://codereview.chromium.org/1129083005/diff/20001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/1129083005/diff/20001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:2123: const SkRRect& rrect =
GrTest::TestRRectSimple(random);
Can this fit on one line ?

[joshualitt, 2015-05-08 13:44:14]

Brian, rubber stamp please

[joshualitt, 2015-05-11 14:15:02]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-11 14:15:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1129083005/#ps40001
(title: "tweaks")

[commit-bot: I haz the power, 2015-05-11 14:15:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129083005/40001

[commit-bot: I haz the power, 2015-05-11 14:21:44]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/21279c7ada1e47e8bfc6375f67768c8eedffb680