ipc/ipc_message_utils.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_utils.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_message_utils.cc

diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc

index b58dce93813f835987acfd3d4e74383576bbf8a4..adb14d1d56c5ef64cbf56e93553989cbe614ee9d 100644

--- a/ipc/ipc_message_utils.cc

+++ b/ipc/ipc_message_utils.cc

@@ -179,7 +179,7 @@ bool ReadValue(const Message* m, PickleIterator* iter, base::Value** value,

switch (type) {

case base::Value::TYPE_NULL:

- *value = base::Value::CreateNullValue();

+ *value = base::Value::CreateNullValue().release();

break;

case base::Value::TYPE_BOOLEAN: {

bool val;

« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | media/base/video_frame_unittest.cc » ('j') | no next file with comments »