extensions/common/event_filtering_info.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/event_filtering_info.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/event_filtering_info.cc

diff --git a/extensions/common/event_filtering_info.cc b/extensions/common/event_filtering_info.cc

index 93b8666e4ab8d39bf7c572743f13342f674f92d3..21809841cc441b82c43f9058f5dba682fe293215 100644

--- a/extensions/common/event_filtering_info.cc

+++ b/extensions/common/event_filtering_info.cc

@@ -30,7 +30,7 @@ void EventFilteringInfo::SetInstanceID(int instance_id) {

scoped_ptr<base::Value> EventFilteringInfo::AsValue() const {

if (IsEmpty())

- return scoped_ptr<base::Value>(base::Value::CreateNullValue());

+ return base::Value::CreateNullValue();

scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue);

if (has_url_)

« no previous file with comments | « extensions/browser/extension_function.cc ('k') | extensions/common/permissions/manifest_permission_set_unittest.cc » ('j') | no next file with comments »