extensions/browser/extension_function.h - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.h

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/extension_function.h

diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h

index a6d814d571237bea8d1193087dbf8d89bac41bf9..3f6f9cecb7e892e6013e010e324536c3f18fc26c 100644

--- a/extensions/browser/extension_function.h

+++ b/extensions/browser/extension_function.h

@@ -200,6 +200,8 @@ class ExtensionFunction

virtual void SetArgs(const base::ListValue* args);

// Sets a single Value as the results of the function.

+ void SetResult(scoped_ptr<base::Value> result);

+ // As above, but deprecated. TODO(estade): remove.

void SetResult(base::Value* result);

// Sets multiple Values as the results of the function.

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »