content/browser/gpu/gpu_internals_ui.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gpu/gpu_internals_ui.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/java/gin_java_script_to_java_types_coercion.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gpu/gpu_internals_ui.cc

diff --git a/content/browser/gpu/gpu_internals_ui.cc b/content/browser/gpu/gpu_internals_ui.cc

index 079c5aae8830a0eed330e6f3cfc075c11f649ae3..adbe274b6bac798856393acf099ee46b045ac61d 100644

--- a/content/browser/gpu/gpu_internals_ui.cc

+++ b/content/browser/gpu/gpu_internals_ui.cc

@@ -221,9 +221,9 @@ base::DictionaryValue* GpuInfoAsDictionaryValue() {

info->Set("basic_info", basic_info);

#if defined(OS_WIN)

- base::Value* dx_info = gpu_info.dx_diagnostics.children.size() ?

- DxDiagNodeToList(gpu_info.dx_diagnostics) :

- base::Value::CreateNullValue();

+ scoped_ptr<base::Value> dx_info = base::Value::CreateNullValue();

+ if (gpu_info.dx_diagnostics.children.size())

+ dx_info.reset(DxDiagNodeToList(gpu_info.dx_diagnostics));

info->Set("diagnostics", dx_info);

#endif

« no previous file with comments | « content/browser/android/java/gin_java_script_to_java_types_coercion.cc ('k') | content/child/v8_value_converter_impl.cc » ('j') | no next file with comments »