components/policy/core/common/schema_map_unittest.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/schema_map_unittest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/registry_dict_win.cc ('k') | content/browser/android/java/gin_java_script_to_java_types_coercion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/schema_map_unittest.cc

diff --git a/components/policy/core/common/schema_map_unittest.cc b/components/policy/core/common/schema_map_unittest.cc

index cf179109145be68b6d4cb7ad0cf13faf3521358c..ef7e336c9b6f810b5f73b2683a91c5246e7dab25 100644

--- a/components/policy/core/common/schema_map_unittest.cc

+++ b/components/policy/core/common/schema_map_unittest.cc

@@ -173,7 +173,7 @@ TEST_F(SchemaMapTest, FilterBundle) {

new base::FundamentalValue(1),

NULL);

map.Set("null", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- base::Value::CreateNullValue(), NULL);

+ base::Value::CreateNullValue().release(), NULL);

map.Set("double",

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,