components/policy/core/common/mac_util.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/mac_util.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/json_schema/json_schema_validator_unittest_base.cc ('k') | components/policy/core/common/registry_dict_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/mac_util.cc

diff --git a/components/policy/core/common/mac_util.cc b/components/policy/core/common/mac_util.cc

index a8b5fcbe4ef65f4b92cc7c7e5a8d04b90e97938d..eb3977896002d8e200c8bc3911c49b662f9881c1 100644

--- a/components/policy/core/common/mac_util.cc

+++ b/components/policy/core/common/mac_util.cc

@@ -45,7 +45,7 @@ void ArrayEntryToValue(const void* value, void* context) {

scoped_ptr<base::Value> PropertyToValue(CFPropertyListRef property) {

if (CFCast<CFNullRef>(property))

- return scoped_ptr<base::Value>(base::Value::CreateNullValue());

+ return base::Value::CreateNullValue();

if (CFBooleanRef boolean = CFCast<CFBooleanRef>(property)) {

return scoped_ptr<base::Value>(new base::FundamentalValue(