Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: slightly shorter code Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/prefs_syncable_service_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc
diff --git a/chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc b/chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc
index 1d1ae6dff5fe3de13742aaf69b468c7923cde071..71f9a44dd3a60ff77110042f3004c3a48b60ef32 100644
--- a/chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc
+++ b/chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc
@@ -78,7 +78,7 @@ TEST(PrefHashCalculatorTest, CatchHashChanges) {
static const char kSeed[] = "0123456789ABCDEF0123456789ABCDEF";
static const char kDeviceId[] = "test_device_id1";
- scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());
+ scoped_ptr<base::Value> null_value = base::Value::CreateNullValue();
scoped_ptr<base::Value> bool_value(new base::FundamentalValue(false));
scoped_ptr<base::Value> int_value(new base::FundamentalValue(1234567890));
scoped_ptr<base::Value> double_value(
« no previous file with comments | « chrome/browser/prefs/prefs_syncable_service_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698