chrome/browser/extensions/api/settings_private/settings_private_apitest.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_apitest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc ('k') | chrome/browser/prefs/pref_model_associator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/settings_private_apitest.cc

diff --git a/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc b/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc

index 21b00464d7b608077003927960ff9638f7ee27a0..8030ed78df3ae01f5ed57d25b048a13be463e639 100644

--- a/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc

+++ b/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc

@@ -34,7 +34,7 @@ class TestDelegate : public SettingsPrivateDelegate {

scoped_ptr<base::Value> GetPref(const std::string& name) override {

if (name.compare(kTestPrefName) != 0)

- return make_scoped_ptr(base::Value::CreateNullValue());

+ return base::Value::CreateNullValue();

return CreateTestPrefObject()->ToValue();

}