base/json/json_writer_unittest.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_writer_unittest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slightly shorter code Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_writer_unittest.cc

diff --git a/base/json/json_writer_unittest.cc b/base/json/json_writer_unittest.cc

index ec60b5eeae768e65b738f29e77b3bba1c01eedbc..a87e5d92066582d0fe658d27d72712a87a6f3c76 100644

--- a/base/json/json_writer_unittest.cc

+++ b/base/json/json_writer_unittest.cc

@@ -12,13 +12,11 @@ TEST(JSONWriterTest, BasicTypes) {

std::string output_js;

// Test null.

- Value* root = Value::CreateNullValue();

- EXPECT_TRUE(JSONWriter::Write(root, &output_js));

+ EXPECT_TRUE(JSONWriter::Write(Value::CreateNullValue().get(), &output_js));

EXPECT_EQ("null", output_js);

- delete root;

// Test empty dict.

- root = new DictionaryValue;

+ Value* root = new DictionaryValue;

EXPECT_TRUE(JSONWriter::Write(root, &output_js));

EXPECT_EQ("{}", output_js);

delete root;

« no previous file with comments | « base/json/json_parser.cc ('k') | base/prefs/json_pref_store.cc » ('j') | no next file with comments »