chrome/browser/ui/webui/options/certificate_manager_handler.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc

index ce0b0c1e903cd6576ab0a31a04f16a8145f50e7d..12b76ef2c779708396d2739dd8af8707de004d99 100644

--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc

@@ -1116,9 +1116,9 @@ void CertificateManagerHandler::ShowError(const std::string& title,

args.push_back(new base::StringValue(title));

args.push_back(new base::StringValue(error));

args.push_back(new base::StringValue(l10n_util::GetStringUTF8(IDS_OK)));

- args.push_back(base::Value::CreateNullValue()); // cancelTitle

- args.push_back(base::Value::CreateNullValue()); // okCallback

- args.push_back(base::Value::CreateNullValue()); // cancelCallback

+ args.push_back(base::Value::CreateNullValue().release()); // cancelTitle

+ args.push_back(base::Value::CreateNullValue().release()); // okCallback

+ args.push_back(base::Value::CreateNullValue().release()); // cancelCallback

web_ui()->CallJavascriptFunction("AlertOverlay.show", args.get());

}