chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « chrome/browser/prefs/tracked/pref_hash_calculator_unittest.cc ('k') | chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

index 9571f0c54654a67d8fd97aefa5ede19c0349db1c..0cf05ddd661a9fa47345259da0cbaafeeb3d88ae 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

@@ -118,7 +118,7 @@ class PreferenceValidationDelegateValues

using base::Value;

switch (value_type) {

case Value::TYPE_NULL:

- return make_scoped_ptr(Value::CreateNullValue());

+ return Value::CreateNullValue();

case Value::TYPE_BOOLEAN:

return scoped_ptr<Value>(new base::FundamentalValue(false));

case Value::TYPE_INTEGER: