base/values.h - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.h

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index ca046f164214c0109177b7e0bfebaf8508d16e73..f60d86f72e549260c769c332933f172cb6aa0032 100644

--- a/base/values.h

+++ b/base/values.h

@@ -64,7 +64,7 @@ class BASE_EXPORT Value {

virtual ~Value();

- static Value* CreateNullValue();

+ static scoped_ptr<Value> CreateNullValue();

// Returns the type of the value stored by the current Value object.

// Each type will be implemented by only one subclass of Value, so it's

« base/json/json_writer_unittest.cc ('K') | « base/test/values_test_util.cc ('k') | base/values.cc » ('j') | base/values.cc » ('J')