base/json/json_parser.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_parser.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/json/json_parser.cc

diff --git a/base/json/json_parser.cc b/base/json/json_parser.cc

index e9a27bc1675da18970f90c5040a2c3b7820c8fbe..4d79be36194ba343925746edcb93a3bc7f42fa66 100644

--- a/base/json/json_parser.cc

+++ b/base/json/json_parser.cc

@@ -932,7 +932,7 @@ Value* JSONParser::ConsumeLiteral() {

return NULL;

}

NextNChars(kNullLen - 1);

- return Value::CreateNullValue();

+ return Value::CreateNullValue().release();

}

default:

ReportError(JSONReader::JSON_UNEXPECTED_TOKEN, 1);

« no previous file with comments | « no previous file | base/json/json_writer_unittest.cc » ('j') | base/json/json_writer_unittest.cc » ('J')