Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/browser/android/java/gin_java_script_to_java_types_coercion.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/core/common/schema_map_unittest.cc ('k') | content/browser/gpu/gpu_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/java/gin_java_script_to_java_types_coercion.cc
diff --git a/content/browser/android/java/gin_java_script_to_java_types_coercion.cc b/content/browser/android/java/gin_java_script_to_java_types_coercion.cc
index cb4e51776b4b507091e1c28590e3def02039e5fe..84b2070366a003ec6fcfaec63f2061d50fd4cc28 100644
--- a/content/browser/android/java/gin_java_script_to_java_types_coercion.cc
+++ b/content/browser/android/java/gin_java_script_to_java_types_coercion.cc
@@ -460,7 +460,7 @@ jobject CoerceJavaScriptListToArray(JNIEnv* env,
if (!result) {
return NULL;
}
- scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());
+ scoped_ptr<base::Value> null_value = base::Value::CreateNullValue();
for (jsize i = 0; i < length; ++i) {
const base::Value* value_element = null_value.get();
list_value->Get(i, &value_element);
@@ -531,7 +531,7 @@ jobject CoerceJavaScriptDictionaryToArray(JNIEnv* env,
if (!result) {
return NULL;
}
- scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());
+ scoped_ptr<base::Value> null_value = base::Value::CreateNullValue();
for (jsize i = 0; i < length; ++i) {
const std::string key(base::IntToString(i));
const base::Value* value_element = null_value.get();
« no previous file with comments | « components/policy/core/common/schema_map_unittest.cc ('k') | content/browser/gpu/gpu_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698