chrome/test/chromedriver/server/http_handler.cc - Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/server/http_handler.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix bad merge Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | components/dom_distiller/content/distiller_page_web_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/server/http_handler.cc

diff --git a/chrome/test/chromedriver/server/http_handler.cc b/chrome/test/chromedriver/server/http_handler.cc

index 5296a932894a8d6e2c21c4795b93fc32017e22cd..279858cd29a5e8cb374c20a16e46b022772d4a33 100644

--- a/chrome/test/chromedriver/server/http_handler.cc

+++ b/chrome/test/chromedriver/server/http_handler.cc

@@ -701,7 +701,7 @@ scoped_ptr<net::HttpServerResponseInfo> HttpHandler::PrepareResponseHelper(

value.reset(error.release());

}

if (!value)

- value.reset(base::Value::CreateNullValue());

+ value = base::Value::CreateNullValue();

base::DictionaryValue body_params;

body_params.SetInteger("status", status.code());

« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | components/dom_distiller/content/distiller_page_web_contents.cc » ('j') | no next file with comments »