Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/ui/webui/options/certificate_manager_handler.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/certificate_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
index ce0b0c1e903cd6576ab0a31a04f16a8145f50e7d..12b76ef2c779708396d2739dd8af8707de004d99 100644
--- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc
@@ -1116,9 +1116,9 @@ void CertificateManagerHandler::ShowError(const std::string& title,
args.push_back(new base::StringValue(title));
args.push_back(new base::StringValue(error));
args.push_back(new base::StringValue(l10n_util::GetStringUTF8(IDS_OK)));
- args.push_back(base::Value::CreateNullValue()); // cancelTitle
- args.push_back(base::Value::CreateNullValue()); // okCallback
- args.push_back(base::Value::CreateNullValue()); // cancelCallback
+ args.push_back(base::Value::CreateNullValue().release()); // cancelTitle
+ args.push_back(base::Value::CreateNullValue().release()); // okCallback
+ args.push_back(base::Value::CreateNullValue().release()); // cancelCallback
web_ui()->CallJavascriptFunction("AlertOverlay.show", args.get());
}

Powered by Google App Engine
This is Rietveld 408576698