Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_apitest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/settings_private/settings_private_apitest.cc
diff --git a/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc b/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc
index 21b00464d7b608077003927960ff9638f7ee27a0..8030ed78df3ae01f5ed57d25b048a13be463e639 100644
--- a/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc
+++ b/chrome/browser/extensions/api/settings_private/settings_private_apitest.cc
@@ -34,7 +34,7 @@ class TestDelegate : public SettingsPrivateDelegate {
scoped_ptr<base::Value> GetPref(const std::string& name) override {
if (name.compare(kTestPrefName) != 0)
- return make_scoped_ptr(base::Value::CreateNullValue());
+ return base::Value::CreateNullValue();
return CreateTestPrefObject()->ToValue();
}

Powered by Google App Engine
This is Rietveld 408576698