Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: base/json/json_writer_unittest.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_parser.cc ('k') | base/prefs/json_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_writer_unittest.cc
diff --git a/base/json/json_writer_unittest.cc b/base/json/json_writer_unittest.cc
index 802876c9859649f1e7fc0fe7349cab6149c5b4f9..5ac2590a0d87ee16d5803c95e43d65529a9ce1bd 100644
--- a/base/json/json_writer_unittest.cc
+++ b/base/json/json_writer_unittest.cc
@@ -12,8 +12,7 @@ TEST(JSONWriterTest, BasicTypes) {
std::string output_js;
// Test null.
- scoped_ptr<Value> root(Value::CreateNullValue());
- EXPECT_TRUE(JSONWriter::Write(root.get(), &output_js));
+ EXPECT_TRUE(JSONWriter::Write(Value::CreateNullValue().get(), &output_js));
EXPECT_EQ("null", output_js);
// Test empty dict.
@@ -57,7 +56,6 @@ TEST(JSONWriterTest, BasicTypes) {
EXPECT_EQ("\"foo\"", output_js);
}
-
TEST(JSONWriterTest, NestedTypes) {
std::string output_js;
« no previous file with comments | « base/json/json_parser.cc ('k') | base/prefs/json_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698