Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Side by Side Diff: base/test/values_test_util.cc

Issue 1129083003: More base::Values-related bare pointer -> scoped_ptr conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix bad merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/prefs/pref_service.cc ('k') | base/values.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/values_test_util.h" 5 #include "base/test/values_test_util.h"
6 6
7 #include "base/json/json_reader.h" 7 #include "base/json/json_reader.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 namespace test { 63 namespace test {
64 64
65 scoped_ptr<Value> ParseJson(base::StringPiece json) { 65 scoped_ptr<Value> ParseJson(base::StringPiece json) {
66 std::string error_msg; 66 std::string error_msg;
67 scoped_ptr<Value> result(base::JSONReader::ReadAndReturnError( 67 scoped_ptr<Value> result(base::JSONReader::ReadAndReturnError(
68 json, base::JSON_ALLOW_TRAILING_COMMAS, 68 json, base::JSON_ALLOW_TRAILING_COMMAS,
69 NULL, &error_msg)); 69 NULL, &error_msg));
70 if (!result) { 70 if (!result) {
71 ADD_FAILURE() << "Failed to parse \"" << json << "\": " << error_msg; 71 ADD_FAILURE() << "Failed to parse \"" << json << "\": " << error_msg;
72 result.reset(Value::CreateNullValue()); 72 result = Value::CreateNullValue();
73 } 73 }
74 return result.Pass(); 74 return result.Pass();
75 } 75 }
76 76
77 } // namespace test 77 } // namespace test
78 } // namespace base 78 } // namespace base
OLDNEW
« no previous file with comments | « base/prefs/pref_service.cc ('k') | base/values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698