Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1129073002: Revert of Revert of Inlining DeathData accessors, per earlier CR's comment (Closed)

Created:
5 years, 7 months ago by vadimt
Modified:
5 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Inlining DeathData accessors, per earlier CR's comment (patchset #1 id:1 of https://codereview.chromium.org/1118753003/) Reason for revert: Since the crash reports started before the original CL landed, reverting the revert. Original issue's description: > Revert of Inlining DeathData accessors, per earlier CR's comment (patchset #1 id:1 of https://codereview.chromium.org/1113463003/) > > Reason for revert: > Suspecting this CL caused crashes (https://code.google.com/p/chromium/issues/detail?id=483255). > > Original issue's description: > > Inlining DeathData accessors, per earlier CR's comment. > > > > BUG=456354 > > > > Committed: https://crrev.com/9e0a3c19c221db002fdd5512b0d56dde675e005b > > Cr-Commit-Position: refs/heads/master@{#327350} > > TBR=asvitkine@google.com,isherman@chromium.org,asvitkine@chromium.org,cpu@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=456354 > > Committed: https://crrev.com/f02f0cc4ee8f12e53cd57a97bd2d6ef4c3af87ff > Cr-Commit-Position: refs/heads/master@{#327798} TBR=asvitkine@google.com,isherman@chromium.org,asvitkine@chromium.org,cpu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456354 Committed: https://crrev.com/b9d054ae28126276b156f55e6d10c25a38914de2 Cr-Commit-Position: refs/heads/master@{#328625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M base/tracked_objects.h View 1 chunk +10 lines, -8 lines 0 comments Download
M base/tracked_objects.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vadimt
Created Revert of Revert of Inlining DeathData accessors, per earlier CR's comment
5 years, 7 months ago (2015-05-06 22:12:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129073002/1
5 years, 7 months ago (2015-05-06 22:12:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 22:15:00 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 22:15:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9d054ae28126276b156f55e6d10c25a38914de2
Cr-Commit-Position: refs/heads/master@{#328625}

Powered by Google App Engine
This is Rietveld 408576698