Extract LazyBackgroundTaskQueue from ExtensionSystem.

Extract LazyBackgroundTaskQueue from ExtensionSystem.

This patch removes lazy_background_task_queue accessor from ExtensionSystem.
It can be its own browser context keyed service.
It can be built by its new factory.

Committed: https://crrev.com/07ea53870ed17c6f4f410c5ae0838cf4fceec1c3
Cr-Commit-Position: refs/heads/master@{#330815}

[juncai, 2015-05-14 02:07:58]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org

[juncai, 2015-05-14 02:07:59]

Hi, please review this patch. Thanks.

[Reilly Grant (use Gerrit), 2015-05-14 16:50:51]

reillyg@chromium.org changed reviewers:
+ asargent@chromium.org
- reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 16:51:09]

reillyg@chromium.org changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2015-05-14 16:51:10]

Let's give Antony a chance to review this one.

[juncai, 2015-05-14 17:18:05]

juncai@chromium.org changed reviewers:
+ atwilson@chromium.org, hashimoto@chromium.org

[juncai, 2015-05-14 17:18:06]

atwilson@chromium.org: Please review changes in
chrome/browser/signin/easy_unlock_app_manager_unittest.cc

hashimoto@chromium.org: Please review changes in
chrome/browser/chromeos/file_manager/file_browser_handlers.cc

[asargent_no_longer_on_chrome, 2015-05-14 21:13:55]

Seems fine overall with 2 small nits to resolve.

nit: The description of the CL has an empty BUG= line. You should either have a
bug for tracking this work and put its number there, or remove the BUG= line
from the description.

https://codereview.chromium.org/1129063011/diff/20001/apps/launcher.cc
File apps/launcher.cc (right):

https://codereview.chromium.org/1129063011/diff/20001/apps/launcher.cc#newcode58
apps/launcher.cc:58: //using extensions::ExtensionSystem;
nit: did you mean to remove this line, instead of just comment it out?

[juncai, 2015-05-16 00:46:40]

removed the line at apps/launcher.cc:58.

Please review this patch.

https://codereview.chromium.org/1129063011/diff/20001/apps/launcher.cc
File apps/launcher.cc (right):

https://codereview.chromium.org/1129063011/diff/20001/apps/launcher.cc#newcode58
apps/launcher.cc:58: //using extensions::ExtensionSystem;
On 2015/05/14 21:13:55, Antony Sargent wrote:
> nit: did you mean to remove this line, instead of just comment it out?

Done.

[Andrew T Wilson (Slow), 2015-05-18 11:55:11]

atwilson@chromium.org changed reviewers:
+ tbarzic@chromium.org

[Andrew T Wilson (Slow), 2015-05-18 11:55:12]

I'm the wrong person to review any easy_unlock stuff. Adding tbarzic.

[asargent_no_longer_on_chrome, 2015-05-18 17:05:15]

lgtm

[tbarzic, 2015-05-18 17:26:35]

easy_unlock* LGTM

[juncai, 2015-05-20 00:36:13]

hashimoto@, ping?

[hashimoto, 2015-05-20 00:45:57]

chrome/browser/chromeos/file_manager/file_browser_handlers.cc lgtm

[juncai, 2015-05-20 00:58:50]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2015-05-20 01:00:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129063011/60001

[commit-bot: I haz the power, 2015-05-20 01:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 01:07:12]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[juncai, 2015-05-20 22:09:05]

The CQ bit was checked by juncai@chromium.org

[juncai, 2015-05-20 22:09:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org, tbarzic@chromium.org, hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1129063011/#ps80001
(title: "rebased from master")

[commit-bot: I haz the power, 2015-05-20 22:13:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1129063011/80001

[commit-bot: I haz the power, 2015-05-20 22:20:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-20 22:21:13]

Patchset 5 (id:??) landed as
https://crrev.com/07ea53870ed17c6f4f410c5ae0838cf4fceec1c3
Cr-Commit-Position: refs/heads/master@{#330815}