Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1129063010: Let LatencyInfo async events be under category "latency_info" (Closed)

Created:
5 years, 7 months ago by Yufeng Shen (Slow to review)
Modified:
5 years, 7 months ago
Reviewers:
nduca
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let LatencyInfo async events be under category "latency_info" BUG=486482 Committed: https://crrev.com/57da3a295c7453c6311b4891d53fc4ae04c39213 Cr-Commit-Position: refs/heads/master@{#330148}

Patch Set 1 #

Patch Set 2 : naming "latency_info" -> "latencyInfo" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/events/latency_info.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yufeng Shen (Slow to review)
trace_viewer side change here https://codereview.appspot.com/238250043/
5 years, 7 months ago (2015-05-13 21:18:45 UTC) #2
nduca
lgtm but lets do camelcase latencyInfo if you're okay with it. it seems more of ...
5 years, 7 months ago (2015-05-15 17:39:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129063010/20001
5 years, 7 months ago (2015-05-15 17:56:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 18:50:19 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:51:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57da3a295c7453c6311b4891d53fc4ae04c39213
Cr-Commit-Position: refs/heads/master@{#330148}

Powered by Google App Engine
This is Rietveld 408576698