Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1129063008: Move mojom definitions of URL{Request,Response} into SDK (Closed)

Created:
5 years, 7 months ago by jamesr
Modified:
5 years, 7 months ago
Reviewers:
viettrungluu, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move mojom definitions of URL{Request,Response} into SDK This moves the definition of the mojom URLRequest and URLResponse objects into the SDK at //mojo/public/interfaces/network/. These are used directly by the shell and have a special place in the system. This patch does the minimal amount of import/include updating to get tests passing but doesn't fully update everything - in particular it doesn't update all the C++ code that #includes url_loader.mojom.h for the URLRequest or URLResponse definitions to #include the more specific mojom.h files, or the equivalent in other languages. I'll do that in a follow-up to minimize churn. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46b709be65425f3d3852b48e1cb3ebd85b762919

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix up deps from other mojoms #

Total comments: 3

Patch Set 4 : update for monet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -129 lines) Patch
M examples/dart/wget/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M examples/dart/wget/main.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/embedder/BUILD.gn View 1 2 3 4 chunks +8 lines, -0 lines 0 comments Download
M mojo/public/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/public/interfaces/network/BUILD.gn View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
A + mojo/public/interfaces/network/http_header.mojom View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
A + mojo/public/interfaces/network/network_error.mojom View 2 chunks +3 lines, -1 line 0 comments Download
A mojo/public/interfaces/network/url_request.mojom View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A mojo/public/interfaces/network/url_response.mojom View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M mojo/services/authenticating_url_loader/public/interfaces/authenticating_url_loader.mojom View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M mojo/services/content_handler/public/interfaces/BUILD.gn View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M mojo/services/content_handler/public/interfaces/content_handler.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/navigation/public/interfaces/BUILD.gn View 1 2 1 chunk +1 line, -9 lines 0 comments Download
M mojo/services/navigation/public/interfaces/navigation.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/BUILD.gn View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M mojo/services/network/public/interfaces/http_connection.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/http_message.mojom View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
D mojo/services/network/public/interfaces/network_error.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/tcp_bound_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/tcp_server_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/udp_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/interfaces/url_loader.mojom View 1 2 3 1 chunk +3 lines, -66 lines 0 comments Download
M mojo/services/network/public/interfaces/web_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/url_response_disk_cache/public/interfaces/BUILD.gn View 1 2 3 1 chunk +1 line, -9 lines 0 comments Download
M mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/network_test.js View 1 chunk +5 lines, -5 lines 0 comments Download
M services/python/mojo_url_redirector/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/python/mojo_url_redirector/__mojo__.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M sky/services/oknet/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M sky/tests/services/network.sky View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jamesr
Green on the bots!
5 years, 7 months ago (2015-05-09 00:01:00 UTC) #2
viettrungluu
LGTM w/extra blank lines removed. https://codereview.chromium.org/1129063008/diff/40001/mojo/public/interfaces/network/network_error.mojom File mojo/public/interfaces/network/network_error.mojom (right): https://codereview.chromium.org/1129063008/diff/40001/mojo/public/interfaces/network/network_error.mojom#newcode11 mojo/public/interfaces/network/network_error.mojom:11: Why oh why? https://codereview.chromium.org/1129063008/diff/40001/mojo/public/interfaces/network/url_response.mojom ...
5 years, 7 months ago (2015-05-09 00:13:09 UTC) #3
qsr
https://codereview.chromium.org/1129063008/diff/40001/mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom File mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom (right): https://codereview.chromium.org/1129063008/diff/40001/mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom#newcode8 mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom:8: import "mojo/services/network/public/interfaces/url_loader.mojom"; This can go away.
5 years, 7 months ago (2015-05-11 11:39:30 UTC) #5
jamesr
On 2015/05/11 11:39:30, qsr wrote: > https://codereview.chromium.org/1129063008/diff/40001/mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom > File > mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom > (right): > > ...
5 years, 7 months ago (2015-05-21 21:30:45 UTC) #6
jamesr
I've updated this on top of the monet update. I'll land this which requires that ...
5 years, 7 months ago (2015-05-27 23:32:55 UTC) #7
jamesr
5 years, 7 months ago (2015-05-28 00:07:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
46b709be65425f3d3852b48e1cb3ebd85b762919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698