Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/chromeos/login/login_browsertest.cc

Issue 1129063003: <gaia-input> element extracted from <gaia-input-form>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Corrected test. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/login/custom_elements_login.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/login_browsertest.cc
diff --git a/chrome/browser/chromeos/login/login_browsertest.cc b/chrome/browser/chromeos/login/login_browsertest.cc
index 46db1d8312ad6c168f6b2cf072d97505c18c6ae1..d999651aae04e2566964a2def6445dcd4fc48fbb 100644
--- a/chrome/browser/chromeos/login/login_browsertest.cc
+++ b/chrome/browser/chromeos/login/login_browsertest.cc
@@ -157,13 +157,13 @@ class LoginTest : public chromeos::LoginManagerTest {
const std::string email_input =
"document.querySelector('#offline-gaia /deep/ #emailInput')";
const std::string email_next_button =
- "document.querySelector('#offline-gaia /deep/ #emailInput "
+ "document.querySelector('#offline-gaia /deep/ #emailSection "
"/deep/ .blue-button')";
const std::string password_input =
"document.querySelector('#offline-gaia /deep/ "
"#passwordInput')";
const std::string password_next_button =
- "document.querySelector('#offline-gaia /deep/ #passwordInput"
+ "document.querySelector('#offline-gaia /deep/ #passwordSection"
" /deep/ .blue-button')";
content::DOMMessageQueue message_queue;
@@ -177,7 +177,7 @@ class LoginTest : public chromeos::LoginManagerTest {
"window.domAutomationController.send('switchToPassword');"
"})";
ASSERT_TRUE(content::ExecuteScript(web_contents(), js));
- std::string set_email = email_input + ".inputValue = '$Email'";
+ std::string set_email = email_input + ".value = '$Email'";
ReplaceSubstringsAfterOffset(&set_email, 0, "$Email", user_email);
ASSERT_TRUE(content::ExecuteScript(web_contents(), set_email));
ASSERT_TRUE(content::ExecuteScript(web_contents(),
@@ -188,7 +188,7 @@ class LoginTest : public chromeos::LoginManagerTest {
LOG(ERROR) << message;
} while (message != "\"switchToPassword\"");
- std::string set_password = password_input + ".inputValue = '$Password'";
+ std::string set_password = password_input + ".value = '$Password'";
ReplaceSubstringsAfterOffset(&set_password, 0, "$Password", password);
ASSERT_TRUE(content::ExecuteScript(web_contents(), set_password));
ASSERT_TRUE(content::ExecuteScript(web_contents(),
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/login/custom_elements_login.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698