Issue 1129053003: MIPS: New hydrogen instruction to reduce cost of growing an array on keyed stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129053003: MIPS: New hydrogen instruction to reduce cost of growing an array on keyed stores. (Closed)

Created:
5 years, 7 months ago by akos.palfi.imgtec

Modified:
5 years, 7 months ago

Reviewers:
mvstanton, dusmil.imgtec, paul.l...

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

MIPS: New hydrogen instruction to reduce cost of growing an array on keyed stores. Port for https://codereview.chromium.org/1124443004/ BUG=

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+268 lines, -2 lines)			Patch
M	src/mips/interface-descriptors-mips.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1	1 chunk	+95 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.h	View		2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/mips64/interface-descriptors-mips64.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips64/lithium-codegen-mips64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips64/lithium-codegen-mips64.cc	View		1 chunk	+95 lines, -0 lines	0 comments	Download
M	src/mips64/lithium-mips64.h	View		2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/mips64/lithium-mips64.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

paul.l...

l-g-t-m for addition to https://codereview.chromium.org/1124443004/

5 years, 7 months ago (2015-05-08 17:44:08 UTC) #2

akos.palfi.imgtec

5 years, 7 months ago (2015-05-12 09:37:31 UTC) #3

Closing, merged into https://codereview.chromium.org/1124443004/.