Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: go/src/infra/tools/cipd/local/manifest_test.go

Issue 1129043003: cipd: Refactor client to make it more readable. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/tools/cipd/local/manifest.go ('k') | go/src/infra/tools/cipd/local/pkgdef.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/tools/cipd/local/manifest_test.go
diff --git a/go/src/infra/tools/cipd/local/manifest_test.go b/go/src/infra/tools/cipd/local/manifest_test.go
new file mode 100644
index 0000000000000000000000000000000000000000..12afdf07bf15cf2d5f5d07bf759cd18a67ec23d7
--- /dev/null
+++ b/go/src/infra/tools/cipd/local/manifest_test.go
@@ -0,0 +1,45 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package local
+
+import (
+ "bytes"
+ "strings"
+ "testing"
+
+ . "github.com/smartystreets/goconvey/convey"
+)
+
+func TestReadManifest(t *testing.T) {
+ var goodManifest = `{
+ "format_version": "1",
+ "package_name": "package/name"
+}`
+
+ Convey("readManifest can read valid manifest", t, func() {
+ manifest, err := readManifest(strings.NewReader(goodManifest))
+ So(manifest, ShouldResemble, Manifest{
+ FormatVersion: "1",
+ PackageName: "package/name",
+ })
+ So(err, ShouldBeNil)
+ })
+
+ Convey("readManifest rejects invalid manifest", t, func() {
+ manifest, err := readManifest(strings.NewReader("I'm not a manifest"))
+ So(manifest, ShouldResemble, Manifest{})
+ So(err, ShouldNotBeNil)
+ })
+
+ Convey("writeManifest works", t, func() {
+ buf := &bytes.Buffer{}
+ m := Manifest{
+ FormatVersion: "1",
+ PackageName: "package/name",
+ }
+ So(writeManifest(&m, buf), ShouldBeNil)
+ So(string(buf.Bytes()), ShouldEqual, goodManifest)
+ })
+}
« no previous file with comments | « go/src/infra/tools/cipd/local/manifest.go ('k') | go/src/infra/tools/cipd/local/pkgdef.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698